Skip to content

fix: add reflect to SceneInstanceReady and other observers/events#16018

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
mrchantey:missing-reflect
Oct 20, 2024
Merged

fix: add reflect to SceneInstanceReady and other observers/events#16018
alice-i-cecile merged 2 commits intobevyengine:mainfrom
mrchantey:missing-reflect

Conversation

@mrchantey
Copy link
Contributor

@mrchantey mrchantey commented Oct 20, 2024

Objective

Built-in observers & events should be Reflect so that components that interact with them can be serialized in scenes. This is a similar pr to #14259.

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types A-Scenes Serialized ECS data stored on the disk S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 20, 2024
@mrchantey mrchantey changed the title fix: add reflect to SceneInstanceReady fix: add reflect to SceneInstanceReady and other observers/events Oct 20, 2024
@alice-i-cecile
Copy link
Member

For context, the bevy_cli working group has added a lint to catch these issues :) TheBevyFlock/bevy_cli#139

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 20, 2024
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 20, 2024
Merged via the queue into bevyengine:main with commit 75096fb Oct 20, 2024
@mrchantey mrchantey deleted the missing-reflect branch November 12, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Reflection Runtime information about types A-Scenes Serialized ECS data stored on the disk C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants