Skip to content

Deduplicate register_inherited_required_components#16519

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Soulghost:feature/reuse_register_inherited_required_components
Feb 26, 2025
Merged

Deduplicate register_inherited_required_components#16519
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Soulghost:feature/reuse_register_inherited_required_components

Conversation

@Soulghost
Copy link
Contributor

Objective

Solution

  • Add a intermediate temporary mutable RequiredComponents to get avoid of the borrowing issues.

Testing

  • I have run cargo test --package bevy_ecs -- --exact --show-output and past all the tests.

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-ECS Entities, components, systems, and events labels Nov 26, 2024
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Nov 26, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 25, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 26, 2025
Merged via the queue into bevyengine:main with commit f2b37c7 Feb 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

3 participants