Deduplicate register_inherited_required_components#16519
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Feb 26, 2025
Merged
Conversation
BenjaminBrienen
approved these changes
Dec 2, 2024
alice-i-cecile
approved these changes
Feb 25, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
register_inherited_required_componentssince the logic is pretty much duplicated, but this needs to use the&mut RequiredComponentslogic for required components #16416Solution
RequiredComponentsto get avoid of the borrowing issues.Testing
cargo test --package bevy_ecs -- --exact --show-outputand past all the tests.