Fix scaling for UI debug overlay

[ickshonpe]

Objective

Fixes #16666

Solution

Multiply the coordinates by the inverse of the window scale factor.

[JeanMertz]

I backported these changes to 0.15 in v0.15.0...JeanMertz:bevy:jean/debug-ui-gizmo-size, but I cannot get the debug lines to show up. The bevy-egui-inspector also doesn't show the entities being created to draw the lines.

Need to investigate what happened, but it might just be a mistake on my side, or the fact that this doesn't backport cleanly to 0.15.

[ickshonpe]

I backported these changes to 0.15 in v0.15.0...JeanMertz:bevy:jean/debug-ui-gizmo-size, but I cannot get the debug lines to show up. The bevy-egui-inspector also doesn't show the entities being created to draw the lines.

Need to investigate what happened, but it might just be a mistake on my side, or the fact that this doesn't backport cleanly to 0.15.

So they worked on main without any problems for you?

I could rewrite the debug visualization to use the UI renderer. It should be simpler and it would work with multiple windows and render to texture etc.

[ickshonpe]

UI renderer PR: #16693

[alice-i-cecile]

@ickshonpe @mockersf I'd like to ship this for 0.15.1: what's the best approach now that #16693 is merged?

[JeanMertz]

@alice-i-cecile i don’t believe that implementation has the same issue. I backported the pr you linked to 0.15 and haven’t had any issues with it.

edit: or are you referring to the fact that that PR won’t be part of 0.15.1, so we still need this fix to land?

[alice-i-cecile]

or are you referring to the fact that that PR won’t be part of 0.15.1, so we still need this fix to land?

Precisely: we don't want to ship the PR that this builds on into 0.15.1 because it's breaking. But it would still be good to have a simple fix for the issue.

[mockersf]

It will probably have to be rewritten on the patch branch. I'll check how hard it is when cherrypicking this PR, and call for help if needed

[ickshonpe]

The changes are really simple so I don't think there should be any problems.

[alice-i-cecile]

I don't think this is impactful enough to spend the time backporting.