Deny derive_more error feature and replace it with thiserror#16684
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Dec 6, 2024
Merged
Deny derive_more error feature and replace it with thiserror#16684alice-i-cecile merged 4 commits intobevyengine:mainfrom
derive_more error feature and replace it with thiserror#16684alice-i-cecile merged 4 commits intobevyengine:mainfrom
Conversation
bushrat011899
added
C-Dependencies
bushrat011899
commented
Dec 6, 2024
bushrat011899
commented
Dec 6, 2024
alice-i-cecile
added
X-Blessed
BenjaminBrienen
approved these changes
Dec 6, 2024
Contributor
BenjaminBrienen
left a comment
BenjaminBrienen
left a comment
There was a problem hiding this comment.
My eyes feel dizzy now lol
Member
|
Github's web interface hates this many files being changed, but I checked out the changes and they look fine. Merging ASAP to avoid merge conflicts. |
alice-i-cecile
added
S-Ready-For-Final-Review
Open
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
…evyengine#16684) # Objective - Remove `derive_more`'s error derivation and replace it with `thiserror` ## Solution - Added `derive_more`'s `error` feature to `deny.toml` to prevent it sneaking back in. - Reverted to `thiserror` error derivation ## Notes Merge conflicts were too numerous to revert the individual changes, so this reversion was done manually. Please scrutinise carefully during review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
derive_more's error derivation and replace it withthiserrorSolution
derive_more'serrorfeature todeny.tomlto prevent it sneaking back in.thiserrorerror derivationNotes
Merge conflicts were too numerous to revert the individual changes, so this reversion was done manually. Please scrutinise carefully during review.