deserialize a ron file to an asset in AssetServer#1673
Closed
mockersf wants to merge 1 commit intobevyengine:mainfrom
Closed
deserialize a ron file to an asset in AssetServer#1673mockersf wants to merge 1 commit intobevyengine:mainfrom
mockersf wants to merge 1 commit intobevyengine:mainfrom
Conversation
alec-deason
approved these changes
Mar 19, 2021
Member
alec-deason
left a comment
There was a problem hiding this comment.
This would replace uglier custom code in my project, that's nice.
huhlig
reviewed
Apr 3, 2021
| } | ||
|
|
||
| impl RonAssetDeserializer for AssetServer { | ||
| fn deserialize<T: for<'de> Deserialize<'de> + Asset>(&self, path: &str) -> Handle<T> { |
Contributor
There was a problem hiding this comment.
This should likely be named something akin to load_ron to match the other load methods.
Member
Author
|
closing with #1665 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR makes it very easy to deserialise any struct as an asset from a ron file:
It depends on #1665 to work, and won't build without.