Merged
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
rparrett
approved these changes
Dec 11, 2024
Contributor
rparrett
left a comment
rparrett
left a comment
There was a problem hiding this comment.
Seems like a good fix for a typo. Examples still seem to work.
rparrett
added
C-Bug
ickshonpe
approved these changes
Dec 11, 2024
Contributor
ickshonpe
left a comment
ickshonpe
left a comment
There was a problem hiding this comment.
Looks good, examples are still working correctly.
BenjaminBrienen
added
D-Straightforward
BenjaminBrienen
approved these changes
Dec 11, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
Trashtalk217
pushed a commit
to Trashtalk217/bevy
that referenced
this pull request
Dec 21, 2024
# Objective Fixes bevyengine#16771 ## Solution Fixed typo in code. ## Testing - Did you test these changes? If so, how? I tested on my own example, that I included in the issue. It was behaving as I expected. Here is the screenshot after fix, the screenshot before the fix can be found in the issue. 
mockersf
pushed a commit
that referenced
this pull request
Jan 3, 2025
# Objective Fixes #16771 ## Solution Fixed typo in code. ## Testing - Did you test these changes? If so, how? I tested on my own example, that I included in the issue. It was behaving as I expected. Here is the screenshot after fix, the screenshot before the fix can be found in the issue. 
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective Fixes bevyengine#16771 ## Solution Fixed typo in code. ## Testing - Did you test these changes? If so, how? I tested on my own example, that I included in the issue. It was behaving as I expected. Here is the screenshot after fix, the screenshot before the fix can be found in the issue. 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #16771
Solution
Fixed typo in code.
Testing
I tested on my own example, that I included in the issue. It was behaving as I expected.
Here is the screenshot after fix, the screenshot before the fix can be found in the issue.
