Remove benchmarks from CI test#16833
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Dec 16, 2024
Merged
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
approved these changes
Dec 15, 2024
alice-i-cecile
added
C-Bug
BD103
added
S-Ready-For-Final-Review
BD103
added a commit
to BD103/bevy
that referenced
this pull request
Dec 26, 2024
This reverts bevyengine#16833.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 29, 2024
# Objective - This reverts #16833, and completely goes against #16803. - Turns out running `cargo test --benches` runs each benchmark once, without timing it, just to ensure nothing panics. This is actually desired because we can use it to verify benchmarks are working correctly without all the time constraints of actual benchmarks. ## Solution - Add the `--benches` flag to the CI test command. ## Testing - `cargo run -p ci -- test`
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective Fixes [Do not test benchmarks in CI bevyengine#16803](bevyengine#16803), part of [Add benchmarks and compile fail tests back to workspace bevyengine#16801](bevyengine#16801) ## Solution Removes the `--benches` flag from the CI tool test. ## Testing `cargo run -p ci --quiet -- test`
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - This reverts bevyengine#16833, and completely goes against bevyengine#16803. - Turns out running `cargo test --benches` runs each benchmark once, without timing it, just to ensure nothing panics. This is actually desired because we can use it to verify benchmarks are working correctly without all the time constraints of actual benchmarks. ## Solution - Add the `--benches` flag to the CI test command. ## Testing - `cargo run -p ci -- test`
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective Fixes [Do not test benchmarks in CI bevyengine#16803](bevyengine#16803), part of [Add benchmarks and compile fail tests back to workspace bevyengine#16801](bevyengine#16801) ## Solution Removes the `--benches` flag from the CI tool test. ## Testing `cargo run -p ci --quiet -- test`
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective - This reverts bevyengine#16833, and completely goes against bevyengine#16803. - Turns out running `cargo test --benches` runs each benchmark once, without timing it, just to ensure nothing panics. This is actually desired because we can use it to verify benchmarks are working correctly without all the time constraints of actual benchmarks. ## Solution - Add the `--benches` flag to the CI test command. ## Testing - `cargo run -p ci -- test`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes Do not test benchmarks in CI #16803, part of Add benchmarks and compile fail tests back to workspace #16801
Solution
Removes the
--benchesflag from the CI tool test.Testing
cargo run -p ci --quiet -- test