Replace impl_param_set proc macro with a macro_rules macro#16847
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Dec 18, 2024
Merged
Replace impl_param_set proc macro with a macro_rules macro#16847alice-i-cecile merged 3 commits intobevyengine:mainfrom
impl_param_set proc macro with a macro_rules macro#16847alice-i-cecile merged 3 commits intobevyengine:mainfrom
Conversation
bushrat011899
approved these changes
Dec 16, 2024
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Dec 16, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
…ngine#16847) # Objective Simplify the code by using `macro_rules` instead of a proc macro where possible. ## Solution Replace `impl_param_set` proc macro with a `macro_rules` macro.
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
…ngine#16847) # Objective Simplify the code by using `macro_rules` instead of a proc macro where possible. ## Solution Replace `impl_param_set` proc macro with a `macro_rules` macro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Simplify the code by using
macro_rulesinstead of a proc macro where possible.Solution
Replace
impl_param_setproc macro with amacro_rulesmacro.