Make RawHandleWrapper fields private to save users from themselves#16968
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Dec 29, 2024
Merged
Make RawHandleWrapper fields private to save users from themselves#16968alice-i-cecile merged 1 commit intobevyengine:mainfrom
RawHandleWrapper fields private to save users from themselves#16968alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
mnmaita
added
A-Windowing
Member
|
Simple docs issue then this LGTM. @spectria-limina, does this line up with what you were hoping for? |
alice-i-cecile
added
the
P-Unsound
Contributor
|
Yes, LGTM after a cursory look. Thanks! |
Brezak
force-pushed
the
hide-raw-handle-wrapper
branch
from
8a2b283 to
7f4c6ec
Compare
alice-i-cecile
approved these changes
Dec 29, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
…evyengine#16968) # Objective Fixes bevyengine#16683 ## Solution Make all fields ine `RawHandleWrapper` private. ## Testing - CI - `cargo clippy` - The lightmaps example --- ## Migration Guide The `window_handle` and `dispay_handle` fields on `RawHandleWrapper` are no longer public. Use the newly added getters and setters to manipulate them instead.
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
…evyengine#16968) # Objective Fixes bevyengine#16683 ## Solution Make all fields ine `RawHandleWrapper` private. ## Testing - CI - `cargo clippy` - The lightmaps example --- ## Migration Guide The `window_handle` and `dispay_handle` fields on `RawHandleWrapper` are no longer public. Use the newly added getters and setters to manipulate them instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #16683
Solution
Make all fields ine
RawHandleWrapperprivate.Testing
cargo clippyMigration Guide
The
window_handleanddispay_handlefields onRawHandleWrapperare no longer public. Use the newly added getters and setters to manipulate them instead.