Merged
Conversation
BenjaminBrienen
added
D-Trivial
Closed
alice-i-cecile
approved these changes
Dec 29, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
There's a broader question of whether or not these crates should all have a listed MSRV, but given that it currently exists it should not be wrong.
alice-i-cecile
added
S-Ready-For-Final-Review
Contributor
Author
|
I can remove the one for input_focus if you want @alice-i-cecile |
BenjaminBrienen
removed
the
S-Ready-For-Final-Review
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective The rust-versions are out of date. Fixes bevyengine#17008 ## Solution Update the values Cherry-picked from bevyengine#17006 in case it is controversial ## Testing Validated locally and in bevyengine#17006 --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective The rust-versions are out of date. Fixes bevyengine#17008 ## Solution Update the values Cherry-picked from bevyengine#17006 in case it is controversial ## Testing Validated locally and in bevyengine#17006 --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The rust-versions are out of date.
Fixes #17008
Solution
Update the values
Cherry-picked from #17006 in case it is controversial
Testing
Validated locally and in #17006