Update from_reflect to return a Result with FromReflectError#17295
Draft
elbertronnie wants to merge 2 commits intobevyengine:mainfrom
Draft
Update from_reflect to return a Result with FromReflectError#17295elbertronnie wants to merge 2 commits intobevyengine:mainfrom
from_reflect to return a Result with FromReflectError#17295elbertronnie wants to merge 2 commits intobevyengine:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
FromReflecttrait #5967.Solution
FromReflectErrorthat enumerates all possible failure cases.Testing
TODO
Showcase
TODO
TODO
Migration Guide
from_reflectcalls with.ok()to convert aResultto anOption.