added any_match_filter common condition

[Jaso333]

Objective

resolves #17326.

Solution

Simply added the suggested run condition.

Testing

A self-explanatory run condition. Fully verified by the operation of QueryFilter in a system.

[github-actions]

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

[alice-i-cecile]

I like this but the name is quite unclear to me :) How about any_match_filter?

[Jaso333]

@alice-i-cecile agreed, it was more of a placeholder name initially, forgot to mention the fact. The documentation above the method even describes it according to your suggestion... 😅

/// A [`Condition`]-satisfying system that returns `true`
/// if there are any entities that match the given [`QueryFilter`].

I have updated the code accordingly.

[benfrankel]

Grammatically it should be any_matches_filter.

EDIT: I guess "any" can be either singular or plural. So I'll amend that to "IMO any_matches_filter reads better".

[Jaso333]

Grammatically it should be any_matches_filter.

EDIT: I guess "any" can be either singular or plural. So I'll amend that to "IMO any_matches_filter reads better".

I think I prefer any_match_filter as its more natural, in my opinion, to think of the "any" as a plural in the context of a set of entities. This was probably due to me thinking the same way with any_with_component, but that also works both ways too!

[chescock]

Do we still need this now that we have Populated? The motivating example in the linked issue seems like it would be better served by replacing Query with Populated, since that avoids having to duplicate the query filters.

[Jaso333]

Do we still need this now that we have Populated? The motivating example in the linked issue seems like it would be better served by replacing Query with Populated, since that avoids having to duplicate the query filters.

There's a few reasons I can think of:

• Populated fails validation and emits a warning when there are no entities. This can be turned off, but it's an extra step that goes against the engine's default behaviour.
• There is another example in my game where I want to run a system if a component combination exists, but I don't want to do anything with those entities. Without this, I would have to include an unused parameter on my system.
• any_with_component already exists, and has the same purpose as this condition, only more restrictive.