Skip to content

Add type registration for PickingInteraction#17372

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
andrewhickman:picking-interaction-type-registration
Jan 15, 2025
Merged

Add type registration for PickingInteraction#17372
alice-i-cecile merged 1 commit intobevyengine:mainfrom
andrewhickman:picking-interaction-type-registration

Conversation

@andrewhickman
Copy link
Contributor

@andrewhickman andrewhickman commented Jan 14, 2025 •
edited
Loading

I noticed that this component was not being returned correctly by the bevy_remote api

"errors": {
  "bevy_picking::focus::PickingInteraction": {
    "code": -23402,
    "message": "Unknown component type: `bevy_picking::focus::PickingInteraction`"
  }
}

@mnmaita mnmaita added D-Trivial Nice and easy! A great choice to get started with Bevy A-Reflection Runtime information about types S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Picking Pointing at and selecting objects of all sorts labels Jan 14, 2025
@BenjaminBrienen BenjaminBrienen added C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 15, 2025
@alice-i-cecile alice-i-cecile added this to the 0.15.2 milestone Jan 15, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 15, 2025
Merged via the queue into bevyengine:main with commit 6ea1574 Jan 15, 2025
35 checks passed
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
@andrewhickman @mrchantey
Add type registration for PickingInteraction (bevyengine#17372)
4517ece 
I noticed that this component was not being returned correctly by the
`bevy_remote` api

```json
"errors": {
  "bevy_picking::focus::PickingInteraction": {
    "code": -23402,
    "message": "Unknown component type: `bevy_picking::focus::PickingInteraction`"
  }
}
```
mockersf pushed a commit that referenced this pull request Feb 6, 2025
@andrewhickman @mockersf
Add type registration for PickingInteraction (#17372)
9afa86e 
I noticed that this component was not being returned correctly by the
`bevy_remote` api

```json
"errors": {
  "bevy_picking::focus::PickingInteraction": {
    "code": -23402,
    "message": "Unknown component type: `bevy_picking::focus::PickingInteraction`"
  }
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@mnmaita mnmaita mnmaita approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Picking Pointing at and selecting objects of all sorts A-Reflection Runtime information about types C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.15.2

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewhickman @BenjaminBrienen @mnmaita @alice-i-cecile