add_edges helper for directional navigation#17389
Merged
alice-i-cecile merged 5 commits intobevyengine:mainfrom Jan 16, 2025
Merged
add_edges helper for directional navigation#17389alice-i-cecile merged 5 commits intobevyengine:mainfrom
add_edges helper for directional navigation#17389alice-i-cecile merged 5 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-UI
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
BenjaminBrienen
approved these changes
Jan 15, 2025
rparrett
reviewed
Jan 15, 2025
Co-authored-by: Rob Parrett <robparrett@gmail.com>
Co-authored-by: Benjamin Brienen <benjamin.brienen@outlook.com>
rparrett
approved these changes
Jan 15, 2025
| /// Add symmetrical edges between each consecutive pair of entities in the provided slice. | ||
| /// | ||
| /// Unlike [`add_looping_edges`](Self::add_looping_edges), this method does not loop back to the first entity. | ||
| pub fn add_edges(&mut self, entities: &[Entity], direction: CompassOctant) { |
Contributor
There was a problem hiding this comment.
A motivated person could follow up to rework add_looping_edges to use reuse add_edges.
viridia
approved these changes
Jan 15, 2025
BenjaminBrienen
added
S-Ready-For-Final-Review
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective While `add_looping_edges` is a helpful method for manually defining directional navigation maps, we don't always want to loop around! ## Solution Add a non-looping variant. These commits are cherrypicked from the more complex bevyengine#17247. ## Testing I've updated the `directional_navigation` example to use these changes, and verified that it works. --------- Co-authored-by: Rob Parrett <robparrett@gmail.com> Co-authored-by: Benjamin Brienen <benjamin.brienen@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
While
add_looping_edgesis a helpful method for manually defining directional navigation maps, we don't always want to loop around!Solution
Add a non-looping variant.
These commits are cherrypicked from the more complex #17247.
Testing
I've updated the
directional_navigationexample to use these changes, and verified that it works.