Update safety docs for Ptr::assert_unique#17394
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Jan 16, 2025
Merged
Update safety docs for Ptr::assert_unique#17394alice-i-cecile merged 3 commits intobevyengine:mainfrom
Ptr::assert_unique#17394alice-i-cecile merged 3 commits intobevyengine:mainfrom
Conversation
joseph-gio
added
P-Unsound
alice-i-cecile
added
S-Needs-Review
alice-i-cecile
approved these changes
Jan 16, 2025
Carter0
approved these changes
Jan 16, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective The safety documentation for `Ptr::assert_unique` is incomplete. Currently it only mentions the existence of other `Ptr` instances, but it should also mention that the underlying data must be mutable and that there cannot be active references to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The safety documentation for
Ptr::assert_uniqueis incomplete. Currently it only mentions the existence of otherPtrinstances, but it should also mention that the underlying data must be mutable and that there cannot be active references to it.