Move Item and fetch to QueryData from WorldQuery #17679
Move Item and fetch to QueryData from WorldQuery #17679alice-i-cecile merged 7 commits intobevyengine:mainfrom
Item and fetch to QueryData from WorldQuery #17679Conversation
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Carter0
left a comment
Carter0
left a comment
There was a problem hiding this comment.
Makes sense. And I think the rust compiler would help guide you through this.
chescock
left a comment
chescock
left a comment
There was a problem hiding this comment.
Looks good! Thanks for fixing this so quickly!
Co-authored-by: Chris Russell <8494645+chescock@users.noreply.github.com>
chescock
added
A-ECS
alice-i-cecile
added
the
M-Migration-Guide
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
|
I've added a migration guide for you :) Really excellent stuff; thanks for tackling this. I hope it was fun and/or educational :D |
These were fixes from changes caused by bevyengine#17679
…17679) # Objective Fixes bevyengine#17662 ## Solution Moved `Item` and `fetch` from `WorldQuery` to `QueryData`, and adjusted their implementations accordingly. Currently, documentation related to `fetch` is written under `WorldQuery`. It would be more appropriate to move it to the `QueryData` documentation for clarity. I am not very experienced with making contributions. If there are any mistakes or areas for improvement, I would appreciate any suggestions you may have. ## Migration Guide The `WorldQuery::Item` type and `WorldQuery::fetch` method have been moved to `QueryData`, as they were not useful for `QueryFilter` types. --------- Co-authored-by: Chris Russell <8494645+chescock@users.noreply.github.com>
4 participants
Objective
Fixes #17662
Solution
Moved
ItemandfetchfromWorldQuerytoQueryData, and adjusted their implementations accordingly.Currently, documentation related to
fetchis written underWorldQuery. It would be more appropriate to move it to theQueryDatadocumentation for clarity.I am not very experienced with making contributions. If there are any mistakes or areas for improvement, I would appreciate any suggestions you may have.
Migration Guide
The
WorldQuery::Itemtype andWorldQuery::fetchmethod have been moved toQueryData, as they were not useful forQueryFiltertypes.