Closed
Conversation
Contributor
|
if i really really want this, what can i do to help? edit: never mind, i was given the generic component propagation pr :D (#17575) |
Contributor
Author
|
I forgot I left this PR open! I realised everything I was doing could be done in userspace, so I did that. A generic solution would be better, it doesn't really make sense to have ad-hoc propagation for everything that might need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Implements #12461.
Solution
Makes
RenderLayersno longer a component, adds componentsVisibleLayersandInheritedVisibleLayersthat work as you'd expect, andVisibleLayersis now required byVisibility.Testing
These changes work on all of the examples that used to use
RenderLayersas a component:pixel_grid_snap,first_person_view_model,order_independent_transparency, andrender_to_texture. I have yet to do any benchmarking. It also seems to work in the more hierarchical example I put in showcase.Showcase
Users can now add
VisibleLayersto a root component of a mesh, and it will inherit down the tree!Click to view showcase
Migration Guide
RenderLayersas a component withVisibleLayers.