Remove insert_or_spawn function family#18148
Remove insert_or_spawn function family#18148alice-i-cecile merged 10 commits intobevyengine:mainfrom
insert_or_spawn function family#18148Conversation
alice-i-cecile
added
A-ECS
ElliottjPierce
added
S-Needs-Review
|
removed |
There was a problem hiding this comment.
There was a comment from Cart in #18054 saying
If we plan on removing support for this, we should also look into some of the "invalid checks" in Entities. Iirc we added additional checking to support this scenario, and we might be able to simplify / optimize some things. Worth digging up the PRs that introduced those changes.
Did someone have a look, if not we could maybe just track this somewhere ?
Yup! I've rewritten most of the Also marking as ready for final since it has two approvals. (I think that's how that's supposed to work.) |
ElliottjPierce
added
S-Ready-For-Final-Review
NthTensor
added
M-Migration-Guide
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
|
Please commit your migration guide as a file following the instructions above. |
Oops. Thanks for pointing that out. Migration guide has been migrated lol. |
NthTensor
added
S-Ready-For-Final-Review
# Objective Based on and closes bevyengine#18054, this PR builds on bevyengine#18035 and bevyengine#18147 to remove: - `Commands::insert_or_spawn_batch` - `Entities::alloc_at_without_replacement` - `Entities::alloc_at` - `entity::AllocAtWithoutReplacement` - `World::insert_or_spawn_batch` - `World::insert_or_spawn_batch_with_caller` ## Testing Just removing unused, deprecated code, so no new tests. Note that as of writing, bevyengine#18035 is still under testing and review. ## Future Work Per [this](bevyengine#18054 (comment)) comment on bevyengine#18054, there may be additional performance improvements possible to the entity allocator now that `alloc_at` no longer is supported. At a glance, I don't see anything obvious to improve, but it may be worth further investigation in the future. --------- Co-authored-by: JaySpruce <jsprucebruce@gmail.com>
6 participants
Objective
Based on and closes #18054, this PR builds on #18035 and #18147 to remove:
Commands::insert_or_spawn_batchEntities::alloc_at_without_replacementEntities::alloc_atentity::AllocAtWithoutReplacementWorld::insert_or_spawn_batchWorld::insert_or_spawn_batch_with_callerTesting
Just removing unused, deprecated code, so no new tests. Note that as of writing, #18035 is still under testing and review.
Future Work
Per this comment on #18054, there may be additional performance improvements possible to the entity allocator now that
alloc_atno longer is supported. At a glance, I don't see anything obvious to improve, but it may be worth further investigation in the future.