Deprecated Query::many and many_mut

[alice-i-cecile]

Objective

Alternative to and closes #18120.

Sibling to #18082, see that PR for broader reasoning.

Folks weren't sold on the name many (get_many is clearer, and this is rare), and that PR is much more complex.

Solution

• Simply deprecate Query::many and Query::many_mut
• Clean up internal usages

Mentions of this in the docs can wait until it's fully removed in the 0.17 cycle IMO: it's much easier to catch the problems when doing that.

Testing

CI!

Migration Guide

Query::many and Query::many_mut have been deprecated to reduce panics and API duplication. Use Query::get_many and Query::get_many_mut instead, and handle the Result.

[alice-i-cecile]

@chescock @bushrat011899 @Carter0, review this one for me?

[chescock]

Looks good!

And the only uses I see in docs are on the many methods themselves, so I think you may have updated all the docs after all :).

[alice-i-cecile]

And the only uses I see in docs are on the many methods themselves, so I think you may have updated all the docs after all

There's an entry for them in an algorithmic complexity table on Query that I didn't clean up this time :)