Return an error when direct-nested-loading a subasset#18213
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Mar 13, 2025
Merged
Return an error when direct-nested-loading a subasset#18213alice-i-cecile merged 4 commits intobevyengine:mainfrom
alice-i-cecile merged 4 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Mar 9, 2025
Member
alice-i-cecile
left a comment
There was a problem hiding this comment.
I really like pushing asset loading towards clear, error-returning behavior. It's way too hard to reason about anything else IMO.
…te-loading a subasset.
a1968f0 to
f0d4968
Compare
Contributor
Author
|
(forgot to rebase before pushing, sorry) |
kristoff3r
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Note an alternative would be to "solve" this problem, by just looking up the appropriate subasset after doing the nested load. However there's two problems: 1) we don't know which subassets of the root asset are necessary for the subasset we are looking up (so any handles in that subasset may never get registered), 2) a solution will likely hamper attempts to resolve #18010. AFAICT, no one has complained about this issue, so it doesn't seem critical to fix this for now.
Testing
CoolTextas the subasset typeSubText(which would have worked had I not been using typed loads).