Move initializing the ScreenshotToScreenPipeline to the ScreenshotPlugin.#18524
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom May 6, 2025
Merged
Move initializing the ScreenshotToScreenPipeline to the ScreenshotPlugin.#18524alice-i-cecile merged 1 commit intobevyengine:mainfrom
ScreenshotToScreenPipeline to the ScreenshotPlugin.#18524alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
andriyDev
added
D-Trivial
greeble-dev
approved these changes
May 1, 2025
Contributor
greeble-dev
left a comment
greeble-dev
left a comment
There was a problem hiding this comment.
Clicking approve as changes seem sensible and I've tested the screenshot example (Win10, Chrome/WebGL, Desktop/Vulkan).
andriyDev
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
May 5, 2025
andrewzhurov
pushed a commit
to andrewzhurov/bevy
that referenced
this pull request
May 17, 2025
…Plugin`. (bevyengine#18524) # Objective - Minor cleanup. - This seems to have been introduced in bevyengine#8336. There is no discussion about it I can see, there's no comment explaining why this is here and not in `ScreenshotPlugin`. This seems to have just been misplaced. ## Solution - Move this to the ScreenshotPlugin! ## Testing - The screenshot example still works at least on desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
ScreenshotPlugin. This seems to have just been misplaced.Solution
Testing