Include SystemParamValidationError in RunSystemError and RegisteredSystemError#18666
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Apr 1, 2025
Merged
Conversation
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Apr 1, 2025
alice-i-cecile
added
D-Straightforward
Member
|
@ElliottjPierce want to review this one too? :) |
ElliottjPierce
approved these changes
Apr 1, 2025
Contributor
ElliottjPierce
left a comment
ElliottjPierce
left a comment
There was a problem hiding this comment.
LGTM!
I love seeing those if expressing converted to maps.
alice-i-cecile
added
S-Ready-For-Final-Review
Member
|
Love to see my TODOs getting cleaned up :) Thanks! |
mockersf
pushed a commit
that referenced
this pull request
Apr 3, 2025
…stemError (#18666) # Objective Provide more useful errors when `World::run_system` and related methods fail parameter validation. Let callers determine whether the validation failure would have skipped or failed the system. Follow-up to #18541. ## Solution Add a `SystemParamValidationError` value to the `RunSystemError::InvalidParams` and `RegisteredSystemError::InvalidParams` variants. That includes the complete context of the parameter validation error, including the `skipped` flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Provide more useful errors when
World::run_systemand related methods fail parameter validation.Let callers determine whether the validation failure would have skipped or failed the system.
Follow-up to #18541.
Solution
Add a
SystemParamValidationErrorvalue to theRunSystemError::InvalidParamsandRegisteredSystemError::InvalidParamsvariants. That includes the complete context of the parameter validation error, including theskippedflag.