No schedule build pass overwrite if build settings do not change auto_insert_apply_deferred from true#19217
Merged
alice-i-cecile merged 15 commits intobevyengine:mainfrom May 26, 2025
Conversation
urben1680
changed the title
auto_insert_apply_deferred from true
Contributor
Author
|
I don't know what is up with that unrelated, failed CI check. |
… of https://github.com/urben1680/bevy into no_pass_overwrite_with_auto_insert_apply_deferred_true
ThierryBerger
approved these changes
May 17, 2025
ThierryBerger
added
C-Bug
improve docs Co-authored-by: Thierry Berger <contact@thierryberger.com>
urben1680
commented
May 17, 2025
PixelDust22
approved these changes
May 19, 2025
andriyDev
added
S-Ready-For-Final-Review
PixelDust22
approved these changes
May 21, 2025
… of https://github.com/urben1680/bevy into no_pass_overwrite_with_auto_insert_apply_deferred_true
Contributor
|
Your PR increases Bevy Minimum Supported Rust Version. Please update the |
Contributor
Author
|
@PixelDust22 I decided taking the extra api away entirely. You are right that the I think that is too much for a bugfix that does not need these methods that much. I also don't want to add new methods to |
ThierryBerger
approved these changes
May 21, 2025
alice-i-cecile
approved these changes
May 26, 2025
mockersf
pushed a commit
that referenced
this pull request
May 30, 2025
…o_insert_apply_deferred` from `true` (#19217) # Objective Fixes #18790. Simpler alternative to #19195. ## Solution As suggested by @PixelDust22, simply avoid overwriting the pass if the schedule already has auto sync points enabled. Leave pass logic untouched. It still is probably a bad idea to add systems/set configs before changing the build settings, but that is not important as long there are no more complex build passes. ## Testing Added a test. --------- Co-authored-by: Thierry Berger <contact@thierryberger.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #18790.
Simpler alternative to #19195.
Solution
As suggested by @PixelDust22, simply avoid overwriting the pass if the schedule already has auto sync points enabled.
Leave pass logic untouched.
It still is probably a bad idea to add systems/set configs before changing the build settings, but that is not important as long there are no more complex build passes.
Testing
Added a test.