Image Node Rotation

[hukasu]

Objective

Adopt #6688
Allow rotation of ImageNodes

Solution

Replace ImageNode::flip_x for rotation, ImageNode::flip_y remains intact

Testing

testbed_full_ui, ui_texture_slice_flip_and_tile and new image_node_rotation examples

Showcase

Deliberate Rendering change

There have been changed to the testbed_full_iu example

TODO

• Include ui slices on the new example
• Migration Guide

[github-actions]

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

[hukasu]

Should the rotation be flipped in flip_y is true?

[ickshonpe]

This misses what I was trying to do with #6688 and #9341 (to be fair part of the reason I gave up on those mostly because a lot of the reviewers misunderstood it too). We can already rotate UI content using Transform::from_rotation(Quat::from_rotation_z(angle)).
The problem though is that after rotation the content no longer fits inside the node's bounds. Those two PR's also recomputed the node's content size so the content would still fit inside the layout.

The main objections to those PRs were that:

• They didn't support arbitrary rotations, only right angles.
• The API was confusing using unfamiliar terms from group theory.
  I don't disagree with them (the other reason I didn't update those PRs), but the UI renderer currently only supports clipping axis-aligned elements atm and you get confusing visual artifacts with clipping and rotation otherwise and I felt that support for axis-aligned transformations was better than nothing.

Maybe it's okay to support arbitrary rotations though and fix clipping later.
To be useful this needs to update the content sizes and image extraction would need to use the size of the image and not the size of the node.

[hukasu]

i did this test to see the behavior of overflow: Overflow::clip() for both using rotation and transform

neither got clipped

[ickshonpe]

i did this test to see the behavior of overflow: Overflow::clip() for both using rotation and transform
neither got clipped

Probably one of two things:

• Overflow::clip() on a parent node tells the UI to clip that node's children if they lay outside the parent's bounds. It shouldn't do anything if you set it on a leaf ImageNode.
• The clipping logic ignores rotations. If the node would be entirely inside the unclipped region before rotation it won't get clipped, even if the rotation moves it outside the clipping rect.

[hukasu]

IIRC I did on the leaf...
One of your PRs were to take rotation into account right?

[ickshonpe]

IIRC I did on the leaf... One of your PRs were to take rotation into account right?

IIRC both of those PRs rotated the image by swapping around the UV coords which avoids any problems with clipping but only supports 90 degree rotations.

I did implement clipping of rotated elements for a bevy 0.13 fork for work but the implementation was a bit limited and slow so I didn't upstream it. I've got an improved very WIP version that might be ready for 0.17.

[hukasu]

Reverted back to draft as there is things to consider

• Should it resize the parent node
• How to clip/overflow
• Picking

[alice-i-cecile]

Cutting from the 0.17 milestone as this is not ready to ship.