Mention Option and When in the error message for a failing system parameter#19490
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jun 4, 2025
Conversation
…a failing system parameter.
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Jun 4, 2025
alice-i-cecile
added
D-Trivial
Member
|
Lovely; that's exactly the sort of polish that goes a long way. |
VitalyAnkh
pushed a commit
to VitalyAnkh/bevy
that referenced
this pull request
Jun 8, 2025
… parameter (bevyengine#19490) # Objective Help users discover how to use `Option<T>` and `When<T>` to handle failing parameters. ## Solution Have the error message for a failed parameter mention that `Option<T>` and `When<T>` can be used to handle the failure. ## Showcase ``` Encountered an error in system `system_name`: Parameter `Res<ResourceType>` failed validation: Resource does not exist If this is an expected state, wrap the parameter in `Option<T>` and handle `None` when it happens, or wrap the parameter in `When<T>` to skip the system when it happens. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Help users discover how to use
Option<T>andWhen<T>to handle failing parameters.Solution
Have the error message for a failed parameter mention that
Option<T>andWhen<T>can be used to handle the failure.Showcase