Skip to content

Allow calling add_render_graph_node on World.#19912

Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom
andriyDev:render-graph-world
Jul 2, 2025
Merged

Allow calling add_render_graph_node on World.#19912
alice-i-cecile merged 3 commits intobevyengine:mainfrom
andriyDev:render-graph-world

Conversation

@andriyDev
Copy link
Contributor

Objective

Solution

  • Rename RenderGraphApp to RenderGraphExt.
  • Implement RenderGraphExt for World.
  • Change SubApp and App to call the World impl.

@andriyDev andriyDev force-pushed the render-graph-world branch from 7f1a9eb to 3bdd675 Compare July 1, 2025 19:35
@andriyDev andriyDev added C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 1, 2025
@andriyDev andriyDev added C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed C-Feature A new feature, making something new possible labels Jul 1, 2025
@andriyDev andriyDev force-pushed the render-graph-world branch from 3bdd675 to a908a7f Compare July 1, 2025 19:40
@andriyDev andriyDev force-pushed the render-graph-world branch from a908a7f to e5506e9 Compare July 1, 2025 19:49
@andriyDev andriyDev requested a review from IceSentry July 1, 2025 20:18
@IceSentry
Copy link
Contributor

Can you explain why it unblocks you? I'm not sure I understand why this change is important

@andriyDev
Copy link
Contributor Author

@IceSentry It's not strictly necessary but it removes a bunch of duplicate code.

I want to add graph nodes in RenderStartup only if the RenderDevice has certain supported features. Since we're in a system, we don't have access to App. I also don't want render graph nodes sitting around doing nothing at best, or blocking things at worst.

Technically I could use the raw RenderGraph API, but that would just mean duplicating all the code here. It's better to just allow us to add graph nodes with World directly the same way we add them to an app.

@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 1, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 2, 2025
Merged via the queue into bevyengine:main with commit f95f42b Jul 2, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants