Allow calling add_render_graph_node on World.#19912
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Jul 2, 2025
Merged
Allow calling add_render_graph_node on World.#19912alice-i-cecile merged 3 commits intobevyengine:mainfrom
add_render_graph_node on World.#19912alice-i-cecile merged 3 commits intobevyengine:mainfrom
Conversation
7f1a9eb to
3bdd675
Compare
3bdd675 to
a908a7f
Compare
a908a7f to
e5506e9
Compare
Contributor
|
Can you explain why it unblocks you? I'm not sure I understand why this change is important |
Contributor
Author
|
@IceSentry It's not strictly necessary but it removes a bunch of duplicate code. I want to add graph nodes in Technically I could use the raw |
IceSentry
approved these changes
Jul 1, 2025
alice-i-cecile
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
RenderGraphApptoRenderGraphExt.RenderGraphExtforWorld.SubAppandAppto call theWorldimpl.