Closed
Conversation
alice-i-cecile
added
A-Rendering
alice-i-cecile
added
C-Feature
Member
|
This needs shader support for at least HSL / HSV color spaces before I am willing to merge this. That should be done in another PR, hence S-Blocked. |
Member
|
#12939 is related and may help. |
Contributor
Author
|
We just need to hook that up to |
Contributor
Author
|
@ickshonpe Thoughts? (on the gradients part of it.) |
Contributor
Bashed out hsl + hsv support out at #19992 very quickly, it's just rough but you can try it out here I guess see if it's acceptable. |
Contributor
😓 should have checked if we had these already before I started all these PRs. |
Contributor
Author
|
Closing in favor of new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Adds color swatch and color slider widgets to Bevy Feathers.
Showcase