Rename When system param to If#20325
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jul 29, 2025
Merged
Conversation
janhohenheim
approved these changes
Jul 29, 2025
janhohenheim
added
D-Trivial
Contributor
|
This is also more in line with |
AlephCubed
approved these changes
Jul 29, 2025
janhohenheim
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Jul 29, 2025
tychedelia
pushed a commit
to tychedelia/bevy
that referenced
this pull request
Jul 31, 2025
# Objective Regardless of where we land on bevyengine#19489, `When` as a system param wrapper is a touch verbose. In many cases, users may find themselves liberally applying `When` to their fallible system params. I believe that `If` maintains the same semantics in a smaller and more readable package, and therefore should replace `When`. ## Showcase `When`: ```rs fn fallible_params(player: When<Single<&mut Velocity, With<Player>>>, gravity: When<Res<Gravity>>) {} ``` `If`: ```rs fn fallible_params(player: If<Single<&mut Velocity, With<Player>>>, gravity: If<Res<Gravity>>) {} ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Regardless of where we land on #19489,
Whenas a system param wrapper is a touch verbose. In many cases, users may find themselves liberally applyingWhento their fallible system params. I believe thatIfmaintains the same semantics in a smaller and more readable package, and therefore should replaceWhen.Showcase
When:If: