Rename the Allows query filter to Allow#20541
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Aug 12, 2025
Merged
Conversation
JaySpruce
added
A-ECS
alice-i-cecile
approved these changes
Aug 12, 2025
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Mild preference for this.
alice-i-cecile
added
D-Trivial
Contributor
|
|
NthTensor
approved these changes
Aug 12, 2025
tychedelia
approved these changes
Aug 12, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the bikeshed of all time, but I needed to bring this up before it became a breaking change.
In my opinion,
Allow<Disabled>sounds better thanAllows<Disabled>.I don't think there's a 1-to-1 comparison in other query keywords yet, but there's the hypothetical
Expectin the discussion on #19489, as opposed toExpects.Allowshasn't been in a release yet, so it's free to change until 0.17 comes out.