[Merged by Bors] - Move to smallvec v1.6#2074
[Merged by Bors] - Move to smallvec v1.6#2074TheRawMeatball wants to merge 2 commits intobevyengine:mainfrom
Conversation
|
Since we're already using latest stable, should be enable the |
|
yes for no for |
|
The docs aren't up-to-date: in 1.6, it compiles on stable :) |
|
Ooh yeah lets enables those features :) |
|
Hmm, what would be a good place to enable these features? I'm adding a |
|
Hmm I think it doesn't matter too much as features are merged across dependencies. Keeping them in sync makes it easier to do a simple "search for Does smallvec respect the soft "features are additive only" rule or will enabling something like const_generics break apis that weren't coded to it? We could also consider re-exporting smallvec from |
From what I can see, |
I don't think that's necessary, those features will be enabled if someone import |
|
bors r+ |
|
Pull request successfully merged into main. Build succeeded: |
| smallvec = "1.4.2" | ||
| # TODO: replace once_cell with std equivalent if/when this lands: https://github.com/rust-lang/rfcs/pull/2788 | ||
| once_cell = "1.4.1" | ||
| smallvec = { version = "1.6", feautres = ["union", "const_generics"] } |
There was a problem hiding this comment.
typo found: feautres => features.
cargo is complaining about this "unused manifest key."
| stretch = "0.3" | ||
| serde = {version = "1", features = ["derive"]} | ||
| smallvec = "1.4" No newline at end of file | ||
| smallvec = { version = "1.6", feautres = ["union", "const_generics"] } No newline at end of file |
There was a problem hiding this comment.
typo found: feautres => features.
cargo is complaining about this "unused manifest key."
they could be fixed in #2111 |
No description provided.