Skip to content

Fix chrome rendering bug#21202

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
atlv24:ad/fix-chrome-bug
Sep 26, 2025
Merged

Fix chrome rendering bug#21202
alice-i-cecile merged 1 commit intobevyengine:mainfrom
atlv24:ad/fix-chrome-bug

Conversation

@atlv24
Copy link
Contributor

@atlv24 atlv24 commented Sep 24, 2025

Objective

  • Fix chrome rendering bug:
image

Solution

Testing

@atlv24 atlv24 added this to the 0.17 milestone Sep 24, 2025
@atlv24 atlv24 added S-Needs-Investigation This issue requires detective work to figure out what's going wrong S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this! labels Sep 24, 2025
JMS55
JMS55 approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@JMS55 JMS55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean I guess we can revert it. But uhh, why does this occur? Can we send some shaders to the dawn team?

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Investigation This issue requires detective work to figure out what's going wrong S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 26, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 26, 2025
@alice-i-cecile alice-i-cecile mentioned this pull request Sep 26, 2025
Open
Merged via the queue into bevyengine:main with commit 5aa5e52 Sep 26, 2025
44 checks passed
mockersf pushed a commit that referenced this pull request Sep 26, 2025
@atlv24 @mockersf
Fix chrome rendering bug (#21202)
ff2c01a 
# Objective

- Fix chrome rendering bug:
<img width="1755" height="985" alt="image"
src="https://github.com/user-attachments/assets/6293a960-b8fa-460e-9d71-e7f2a9fb2d20"
/>

## Solution

- Revert part of #20313
- I don't know why this fixes it, but #20960 also ran into it

## Testing

-
@diyu-motif diyu-motif mentioned this pull request Sep 26, 2025
Merged
@atlv24 atlv24 deleted the ad/fix-chrome-bug branch October 24, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tychedelia tychedelia tychedelia approved these changes

@JMS55 JMS55 JMS55 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.17

Development

Successfully merging this pull request may close these issues.

4 participants

@atlv24 @tychedelia @JMS55 @alice-i-cecile