Implementation of Dynamic Plugins#21252
Conversation
Co-authored-by: Chris Biscardi <chris@christopherbiscardi.com>
150dbfe to
b874cc6
Compare
|
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
alice-i-cecile
left a comment
There was a problem hiding this comment.
Quick review thoughts from Discord:
[21:24]Alice 🌹
: Generally quite reluctant to add any features / encouragement to use subapps frankly
[21:25]Alice 🌹
: They are a major area of tech debt, and I have been unimpressed with the core architecture around them
[21:25]Alice 🌹
: Similarly for adding more features / complexity to plugins
[21:26]Alice 🌹
: I'm pleased that there's an example, but the example still doesn't motivate "why" you would ever want to modify a subapp at runtime
Depends on #20975, #21239 and #20298
Objective
Solution
Plugintrait:fn is_dynamic(&self) -> boolandfn remove(&self, app: &mut App)Testing