Make RecordDiagnostics::time_span take CommandEncoder#21504
Open
akimakinai wants to merge 3 commits intobevyengine:mainfrom
Open
Make RecordDiagnostics::time_span take CommandEncoder#21504akimakinai wants to merge 3 commits intobevyengine:mainfrom
RecordDiagnostics::time_span take CommandEncoder#21504akimakinai wants to merge 3 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Oct 13, 2025
kristoff3r
reviewed
Oct 16, 2025
| /// | ||
| /// Returns a guard, which will panic on drop unless you end the span. | ||
| fn time_span<E, N>(&self, encoder: &mut E, name: N) -> TimeSpanGuard<'_, Self, E> | ||
| fn time_span<E, N>(&self, encoder: &mut CommandEncoder, name: N) -> TimeSpanGuard<'_, Self, E> |
Contributor
There was a problem hiding this comment.
I don't fully understand the context of this change, but I checked and the E is entirely unused after this, so it and the PhantomData should be removed from TimeSpanGuard.
alice-i-cecile
added
S-Waiting-on-Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
RenderDiagnosticsPlugin#21167 / Fix crash with RenderDiagnosticsPlugin on mac #21238Solution
RecordDiagnostics::time_spantakeCommandEncoderinstead of being generic over command encoder or passTesting
cargo checkpasses