Skip to content

Update size and metrics after set_rich_text in TextPipeline::update_buffer #22021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mockersf merged 4 commits into from
Dec 7, 2025
Merged

Update size and metrics after set_rich_text in TextPipeline::update_buffer #22021

mockersf merged 4 commits into from
Dec 7, 2025
+4 −6

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Dec 3, 2025 •
edited
Loading

Objective

Rearrange the order that cosmic text's properties are set for improved performance.

Solution

Update size and metrics after set_rich_text in TextPipeline::update_buffer

Testing

yellow = this PR, red = main:

cargo run --example many_glyphs --features=trace_tracy,debug --release -- --recompute-text
reorder reorder-measure-text

@ickshonpe ickshonpe added D-Trivial Nice and easy! A great choice to get started with Bevy C-Performance A change motivated by improving speed, memory usage or compile times A-Text Rendering and layout for characters S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 3, 2025
@ickshonpe ickshonpe changed the title update size and metrics after set_rich_text in `TextPipeline::updat… Update size and metrics after set_rich_text in TextPipeline::update_buffer Dec 3, 2025
@ickshonpe ickshonpe added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 6, 2025
@mockersf mockersf added this pull request to the merge queue Dec 7, 2025
Merged via the queue into bevyengine:main with commit 84e1278 Dec 7, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cart cart cart approved these changes

@mockersf mockersf mockersf approved these changes

+1 more reviewer

@kfc35 kfc35 kfc35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Text Rendering and layout for characters C-Performance A change motivated by improving speed, memory usage or compile times D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ickshonpe @kfc35 @cart @mockersf