Make write_default_meta_file_for_path write the short type path instead of the long type path.#22208
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Feb 22, 2026
Merged
Conversation
e53672f to
fa25d98
Compare
fa25d98 to
8fc6fe3
Compare
202b7d4 to
3360341
Compare
3360341 to
3ae014f
Compare
kfc35
approved these changes
Dec 23, 2025
Contributor
kfc35
left a comment
There was a problem hiding this comment.
Another test case you could add if you wanted to is that it still writes the short type with two processors that are unique (not ambiguous), or you could just augment the existing test for writes_short_default_meta_for_processor with a second unique processor registered, but this suggestion can be ignored
95bfe59 to
00ef04e
Compare
alice-i-cecile
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
ErasedProcessorhave a method for returning itsshort_type_path, and make itsdefault_metamethod take an enum to choose between using the short or long type path.\nas the new line character.write_default_meta_file_for_pathandwrite_default_loader_meta_file_for_pathwhich were omitted in Stop automatically generating meta files for assets while using asset processing. #17216 due to missing appropriate testing utilities (specifically a memory asset writer).Testing