Delete InstrumentedAssetLoader and InstrumentedAssetProcessor, but keep the instrumentation.#22213
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Dec 22, 2025
Merged
Conversation
kristoff3r
approved these changes
Dec 20, 2025
kfc35
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
InstrumentedAssetLoaderandInstrumentedAssetProcessor.ErasedAssetLoader::{default_meta, type_path}andErasedProcessor::default_metacan return the wrong type path when using thetracefeature, and this type path could be written into a meta file, which will be rendered unloadable/unprocessable.tracewritten meta files, buttracewritten meta files would fail to load whethertracewas enabled or not!Solution
loadand a single callsite ofprocess- very good!Testing
asset_processingexample for both loading and processing.Note: We don't need a migration guide since users should really not be using these directly, and any meta files using these would just be broken.