Gate Render Diagnostics for MacOS

[kfc35]

Objective

Help out with #22257

Solution

There is an open question about whether render diagnostics might be causing the flickering for MacOS, so this gates any render diagnostic code such that MacOS targets do not include them. They supposedly do not work on MacOS anyway, so this shouldn’t affect anything. (Should I also add ios as a not target?)

Testing

Unfortunately, I’m not affected by the bug, but hopefully other people can test this. If this actually solves the flickering problem, I can take this out of draft.

To try to see if this solves the issue, run cargo run --example bloom_3d --features=trace_tracy with many instances and also several times, and see if you can get flickering. This should be done particularly if you are on MacOS, and please note which OS you are using (since it seems to only affect Tahoe but you never know)

[hukasu]

I would rather have it be a feature (:bike: :hut: trace_tracy_gpu) instead of locking based on os, because it is not all macos that is having that

[aevyrie]

A much simpler fix I found was to just feature gate RenderDiagnosticsPlugin.

because it is not all macos that is having that

It appears to be affecting the latest MacOS version, so eventually all Mac users will hit this. Render diagnostics don't work on Mac anyway, so I don't see the harm in just gating the plugin on OS anyway.

/// # Supported platforms
/// Timestamp queries and pipeline statistics are currently supported only on Vulkan and DX12.
/// On other platforms (Metal, WebGPU, WebGL2) only CPU time will be recorded.

Ah, so we probably don't want to gate the entire plugin, just the timestamp queries and similar, assuming that fixes the issue.

[aevyrie]

I have an alternative that is more surgical and seems to work: #22365

[kfc35]

Nice! Closing this then