0.18: Remove references to ReaderRequiredFeatures#22430
0.18: Remove references to ReaderRequiredFeatures#22430alice-i-cecile merged 4 commits intobevyengine:release-0.18.0from
ReaderRequiredFeatures#22430Conversation
greeble-dev
added
C-Bug
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
|
I think the pixel eagle warning might be a red herring due to this PR targeting the 0.18 branch? |
Yep there’s an issue to address this #22368 |
| which may not support seeking backwards). However, it also meant that we could no longer use seeking | ||
| fully where it was available. | ||
|
|
||
| To resolve this issue, we now allow `AssetLoader`s to provide a `ReaderRequiredFeatures` to the |
There was a problem hiding this comment.
This release notes is still relevant, but we need to rewrite this to remove references to ReaderRequiredFeatures and point people to seekable.
If you don't get to it before I do, I'll PR your branch.
There was a problem hiding this comment.
I'll defer to you on the release note.
Maybe worth noting that Alice had flagged up the original release note as needing more context (#22421)
- optional_asset_reader_seek.md
- cut or add more context on what this enables
There was a problem hiding this comment.
I think that seekable assets are probably worth covering, but we need to do a better job explaining why this is impactful.
There was a problem hiding this comment.
In that case, can we bring back this file and then just add a TODO on it to fix it to reference seekable? This can be expanded on later, I just don't want to delete this and forget about it, or forget to make it match the published lib.
|
Following #22430 (comment), I've restored the release note but added a TODO. Since this PR fixes a CI failure, I'm assuming it's best to push it through even if the release notes aren't finished. |
alice-i-cecile
merged commit 900f508
into
bevyengine:release-0.18.0
alice-i-cecile
added
S-Ready-For-Final-Review
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
|
Ack, looks like this breaks CI due to markdown lint. I'm not sure how to move forward. Let me know if I should fix in this branch or start a new PR. |
|
@greeble-dev this PR is merged, so I think start a new branch on main? Happy to approve. |
5 participants
ReaderRequiredFeatureswas added by #22104 and removed by #22182, but some references snuck into the 0.18 branch. This was causing a compile error if thetracefeature was enabled, and some release content was misleading.