Store registered system as Option and take it when running #22437
Merged
cart merged 2 commits intobevyengine:mainfrom Jan 8, 2026
Merged
Store registered system as Option and take it when running #22437cart merged 2 commits intobevyengine:mainfrom
cart merged 2 commits intobevyengine:mainfrom
Conversation
cart
added
C-Bug
alice-i-cecile
added
the
S-Needs-Review
alice-i-cecile
approved these changes
Jan 8, 2026
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
That's a clean design!
hukasu
approved these changes
Jan 8, 2026
CorvusPrudens
approved these changes
Jan 8, 2026
Member
CorvusPrudens
left a comment
CorvusPrudens
left a comment
There was a problem hiding this comment.
I can also confirm the panic is resolved!
alice-i-cecile
added
S-Ready-For-Final-Review
cart
added a commit
that referenced
this pull request
Jan 9, 2026
# Objective Fixes #22380 ## Solution - Store the registered system as Option - Take it when running instead of removing `RegisteredSystem` This prevents a flush of the global command buffer and also enables running one-shot systems without changing the shape of entities (opening up DeferredWorld scenarios). ## Testing - Tested the repro in #22380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #22380
Solution
RegisteredSystemThis prevents a flush of the global command buffer and also enables running one-shot systems without changing the shape of entities (opening up DeferredWorld scenarios).
Testing