Merged
Conversation
ElliottjPierce
added
C-Bug
cart
approved these changes
Jan 23, 2026
mockersf
approved these changes
Jan 23, 2026
beicause
pushed a commit
to beicause/bevy
that referenced
this pull request
Jan 24, 2026
# Objective bevyengine#18670 introduced a small but fatal issue with batch spawning. Previous tests did not catch this bug because they tested `alloc` and `alloc_many` separately. ## Solution - Fix an off by one math mistake in `FreeBufferIterator::next`. - Fix the part where you need to `ptr.add(index)` if you want the element at `index`. Whoops. - Add a test to catch these issues next time ## Testing - CI - One new test - This was originally found [here](https://discord.com/channels/691052431525675048/749335865876021248/1464359124950319114), and the reproduction crashes on main but is fine on this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
#18670 introduced a small but fatal issue with batch spawning. Previous tests did not catch this bug because they tested
allocandalloc_manyseparately.Solution
FreeBufferIterator::next.ptr.add(index)if you want the element atindex. Whoops.Testing