Skip to content

get game_menu running again#22899

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
ChristopherBiscardi:settings-menu
Feb 11, 2026
Merged

get game_menu running again#22899
alice-i-cecile merged 2 commits intobevyengine:mainfrom
ChristopherBiscardi:settings-menu

Conversation

@ChristopherBiscardi
Copy link
Contributor

@ChristopherBiscardi ChristopherBiscardi commented Feb 11, 2026

Objective

fixes #22897

Solution

Introduces a new generic Setting component to differentiate between the Resource and the Component. This example was using one type as both uses.

Testing

cargo run --example game_menu
screenshot-2026-02-10-at-18.55.46-converted.mp4

@ChristopherBiscardi ChristopherBiscardi added A-ECS Entities, components, systems, and events A-UI Graphical user interfaces, styles, layouts, and widgets S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 11, 2026
Copy link
Contributor

@Trashtalk217 Trashtalk217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and good solution

@kfc35 kfc35 added this to the 0.19 milestone Feb 11, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 11, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 11, 2026
Merged via the queue into bevyengine:main with commit 4c23352 Feb 11, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events A-UI Graphical user interfaces, styles, layouts, and widgets S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

example game_menu crashes with a query conflicts since resources as components

4 participants