clear_all() clears all (non-send data)#22911
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Feb 17, 2026
Merged
Conversation
alice-i-cecile
approved these changes
Feb 11, 2026
Member
|
Is there any reason why this is in draft? |
11 tasks
Contributor
Author
|
The draft was a mistake. I'm not sure why this was marked 'M-migration-guide', I've added a small note at the bottom of the resources-as-components migration guide. I also think this is no longer blocked, since we no longer plan to revert #20934. |
Member
This label should persist even after the migration guide is easier, to help people looking to bisect breaking changes :) Sounds good to me otherwise; I'm fine to merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Since #20934,
World::clear_allandWorld::clear_all_entitiesbehave identically.World::clear_allused to clear all resources and entities, but since resources are now components,World::clear_all_entitiesalso does this.Solution
Since
World::clear_all_non_send()was not included inWorld::clear_all, I've decided to include it.