Skip to content

clear_all() clears all (non-send data)#22911

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Trashtalk217:clear_all
Feb 17, 2026
Merged

clear_all() clears all (non-send data)#22911
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Trashtalk217:clear_all

Conversation

@Trashtalk217
Copy link
Contributor

Objective

Since #20934, World::clear_all and World::clear_all_entities behave identically. World::clear_all used to clear all resources and entities, but since resources are now components, World::clear_all_entities also does this.

Solution

Since World::clear_all_non_send() was not included in World::clear_all, I've decided to include it.

@Trashtalk217 Trashtalk217 added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events labels Feb 11, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Feb 11, 2026
@alice-i-cecile
Copy link
Member

Is there any reason why this is in draft?

@cart cart added this to ECS Feb 12, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in ECS Feb 12, 2026
@alice-i-cecile alice-i-cecile added S-Blocked This cannot move forward until something else changes and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 12, 2026
@alice-i-cecile alice-i-cecile added this to the 0.19 milestone Feb 12, 2026
@alice-i-cecile alice-i-cecile moved this from Needs SME Triage to SME Triaged in ECS Feb 12, 2026
@Trashtalk217 Trashtalk217 marked this pull request as ready for review February 13, 2026 00:10
@Trashtalk217
Copy link
Contributor Author

The draft was a mistake. I'm not sure why this was marked 'M-migration-guide', I've added a small note at the bottom of the resources-as-components migration guide.

I also think this is no longer blocked, since we no longer plan to revert #20934.

@Trashtalk217 Trashtalk217 removed S-Blocked This cannot move forward until something else changes M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Feb 15, 2026
@alice-i-cecile alice-i-cecile added M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 16, 2026
@alice-i-cecile
Copy link
Member

I'm not sure why this was marked 'M-migration-guide', I've added a small note at the bottom of the resources-as-components migration guide.

This label should persist even after the migration guide is easier, to help people looking to bisect breaking changes :)

Sounds good to me otherwise; I'm fine to merge this in.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 16, 2026
Merged via the queue into bevyengine:main with commit 48f5911 Feb 17, 2026
53 checks passed
@cart cart moved this from SME Triaged to Done in ECS Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events D-Trivial Nice and easy! A great choice to get started with Bevy M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants