[pbr] Create a DirectionalLightBundle#2367
Closed
dannymcgee wants to merge 5 commits intobevyengine:mainfrom
Closed
[pbr] Create a DirectionalLightBundle#2367dannymcgee wants to merge 5 commits intobevyengine:mainfrom
dannymcgee wants to merge 5 commits intobevyengine:mainfrom
Conversation
TheRawMeatball
approved these changes
Jun 20, 2021
NathanSWard
reviewed
Jun 20, 2021
NathanSWard
suggested changes
Jun 20, 2021
mockersf
approved these changes
Jun 21, 2021
Member
|
bors try |
Contributor
tryBuild failed: |
NathanSWard
reviewed
Jun 21, 2021
NathanSWard
suggested changes
Jun 21, 2021
NathanSWard
approved these changes
Jun 22, 2021
Member
|
Normally I would merge this because it is relatively uncontroversial and provides useful functionality, but we are planning on overhauling bevy_render prior to 0.6 and I'd prefer to hold off on merging more changes to the current renderer. I think we should leave this open. If the renderer overhaul lands prior to 0.6 (which we're working very hard to do), we can close this out. If not, we can merge this to provide some extra value in 0.6. |
Member
|
there is now a bevy/crates/bevy_pbr/src/bundle.rs Lines 70 to 78 in add1818 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
DirectionalLightBundleinbevy_pbrwithTransformandGlobalTransformcomponentsDirectionalLightcomponent to thePbrPlugin's registered types3d_sceneexample by replacing thePointLightBundlewith theDirectionalLightBundle**I tried to keep the appearance of the lighting pretty close to the original scene, so the only real difference should be that the new light doesn't have any fall-off. But I could create a new example instead if that would be preferred.