[Merged by Bors] - Optional .system(), part 3#2422
Closed
Ratysz wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Optional .system(), part 3#2422Ratysz wants to merge 2 commits intobevyengine:mainfrom
.system(), part 3#2422Ratysz wants to merge 2 commits intobevyengine:mainfrom
Conversation
mockersf
added
core
A-ECS
mockersf
approved these changes
Jul 1, 2021
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2021
# Objective - Continue work of #2398 and #2403. - Make `.system()` syntax optional when using `.config()` API. ## Solution - Introduce new prelude trait, `ConfigurableSystem`, that shorthands `my_system.system().config(...)` as `my_system.config(...)`. - Expand `configure_system_local` test to also cover the new syntax.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
.system(), part 3.system(), part 3
Ratysz
added
C-Usability
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective - Continue work of bevyengine#2398 and bevyengine#2403. - Make `.system()` syntax optional when using `.config()` API. ## Solution - Introduce new prelude trait, `ConfigurableSystem`, that shorthands `my_system.system().config(...)` as `my_system.config(...)`. - Expand `configure_system_local` test to also cover the new syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
.system#2398 and [Merged by Bors] - Optional.system(), part 2 #2403..system()syntax optional when using.config()API.Solution
ConfigurableSystem, that shorthandsmy_system.system().config(...)asmy_system.config(...).configure_system_localtest to also cover the new syntax.