[Merged by Bors] - Optional .system(), part 4 (run criteria)#2431
Closed
Ratysz wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Optional .system(), part 4 (run criteria)#2431Ratysz wants to merge 1 commit intobevyengine:mainfrom
.system(), part 4 (run criteria)#2431Ratysz wants to merge 1 commit intobevyengine:mainfrom
Conversation
Ratysz
added
core
C-Usability
mockersf
approved these changes
Jul 5, 2021
alice-i-cecile
approved these changes
Jul 6, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 8, 2021
# Objective - Continue work of #2398 and friends. - Make `.system()` optional in run criteria APIs. ## Solution - Slight change to `RunCriteriaDescriptorCoercion` signature and implementors. - Implement `IntoRunCriteria` for `IntoSystem` rather than `System`. - Remove some usages of `.system()` with run criteria in tests of `stage.rs`, to verify the implementation.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
.system(), part 4 (run criteria).system(), part 4 (run criteria)
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective - Continue work of bevyengine#2398 and friends. - Make `.system()` optional in run criteria APIs. ## Solution - Slight change to `RunCriteriaDescriptorCoercion` signature and implementors. - Implement `IntoRunCriteria` for `IntoSystem` rather than `System`. - Remove some usages of `.system()` with run criteria in tests of `stage.rs`, to verify the implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
.system#2398 and friends..system()optional in run criteria APIs.Solution
RunCriteriaDescriptorCoercionsignature and implementors.IntoRunCriteriaforIntoSystemrather thanSystem..system()with run criteria in tests ofstage.rs, to verify the implementation.