[Merged by Bors] - Add examples for Transforms

[sneakymizu]

Add Transform Examples

• Adding examples for moving/rotating entities (with its own section) to resolve Add a transform and Quaternion example section.  #2400

I've stumbled upon this project and been fiddling around a little. Saw the issue and thought I might just add some examples for the proposed transformations.
Mind to check if I got the gist correctly and suggest anything I can improve?

[alice-i-cecile]

bors try

[bors]

try

Build failed:

• check-missing-examples-in-docs

[NathanSWard]

This looks like a nice addition.

Note, you'll also have to update the README.md inside the examples/ directory.

[NathanSWard]

Also as a quick note, it's nice if inside the examples themselves, there are more comments explaining what's happening.
Adding some comments to explain what each system does, what you're spawning in the setup systems, would be a nice addition 😄

[alice-i-cecile]

As the CI noted, you need to add these to the examples README :)

[alice-i-cecile]

Good stuff! This is really helpful.

Two areas of content that I think should be addressed in this section eventually:

• more guidance on how to work with rotations: probably a few more examples for them and a pointer to [Quat]'s methods. I've seen lots of confusion around quaternions, axes of rotation, how to use them in a 2D context and so on. @bitshifter, would a docs PR (from me) to glam's Quat with a glossary of terms be welcome here? We're just re-exporting it, so that's where the docs should be changed
• non-uniform scaling (@cart, have you come to a decision about what we should do about this in the engine as a whole?)

[bitshifter]

* more guidance on how to work with rotations: probably a few more examples for them and a pointer to [`Quat`]'s methods. I've seen lots of confusion around quaternions, axes of rotation, how to use them in a 2D context and so on. @bitshifter, would a docs PR (from me) to `glam`'s `Quat` with a glossary of terms be welcome here? We're just re-exporting it, so that's where the docs should be changed

I'm happy to look at a PR or an issue to improve documentation. What did you have in mind glossary wise? The use of quaternions for rotations in 2D may be a bit bevy specific? I'd not sure what docs for a non bevy audience would look like there. Probably the easiest way to progress would be via either https://github.com/bitshifter/glam-rs/discussions or https://github.com/bitshifter/glam-rs/issues.

[sneakymizu]

Just so you all know, I've seen all your comments and am baffled at the speed of your reaction. 😄
I'll work through your suggestions, but I might need some time. Hope you don't mind if i'm a bit slow with the rework.

[sneakymizu]

So I tried to rework the global vs local translation example as suggested by RustyStriker. I do think the code does get somewhat simpler when enabling interaction even though it now contains multiple aspects of bevy. However it's a more complex thing and I hope the way I defined the systems keeps it somewhat distinguished.
For now I'd like to refrain from changing the more simpler examples for the same reason. It'd seem to me that adding inputs and even text would distract form the basic goal of the example, even if the current way for decisions in these examples might not be ideal...

However, I try to keep up to date with main, but I haven't figured out what the advisories-check wants me to do. I don't think I changed dependencies, so it's a bit confusing to me that it says that there are security advisories or unmaintained crates. I cannot see additional information either. Is someone of you able to help me with that?

[alice-i-cecile]

However, I try to keep up to date with main, but I haven't figured out what the advisories-check wants me to do. I don't think I changed dependencies, so it's a bit confusing to me that it says that there are security advisories or unmaintained crates. I cannot see additional information either. Is someone of you able to help me with that?

This is a global Bevy issue: one of our dependencies started triggering this about a month back. Your PR is fine; just ignore it.

[alice-i-cecile]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• build-android
• build (nightly, ubuntu-latest)
• build (stable, macos-latest)
• build (stable, ubuntu-latest)
• build (stable, windows-latest)
• build-wasm (nightly, ubuntu-latest)
• build-wasm (stable, ubuntu-latest)
• check-benches
• check-doc
• check-markdown-links
• check-missing-examples-in-docs
• check-unused-dependencies
• ci
• markdownlint
• run-examples