[Merged by Bors] - Optional .system(), part 6 (chaining)#2494
Closed
Ratysz wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Optional .system(), part 6 (chaining)#2494Ratysz wants to merge 1 commit intobevyengine:mainfrom
.system(), part 6 (chaining)#2494Ratysz wants to merge 1 commit intobevyengine:mainfrom
Conversation
Ratysz
added
A-ECS
mockersf
approved these changes
Jul 17, 2021
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2021
# Objective - Continue work of #2398 and friends. - Make `.system()` optional in chaining. ## Solution - Slight change to `IntoChainSystem` signature and implementation. - Remove some usages of `.system()` in the chaining example, to verify the implementation. --- I swear, I'm not splitting these up on purpose, I just legit forgot about most of the things where `System` appears in public API, and my trait usage explorer mingles that with the gajillion internal uses. In case you're wondering what happened to part 5, #2446 ate it.
Contributor
bors
bot
changed the title
.system(), part 6 (chaining).system(), part 6 (chaining)
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective - Continue work of bevyengine#2398 and friends. - Make `.system()` optional in chaining. ## Solution - Slight change to `IntoChainSystem` signature and implementation. - Remove some usages of `.system()` in the chaining example, to verify the implementation. --- I swear, I'm not splitting these up on purpose, I just legit forgot about most of the things where `System` appears in public API, and my trait usage explorer mingles that with the gajillion internal uses. In case you're wondering what happened to part 5, bevyengine#2446 ate it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
.system#2398 and friends..system()optional in chaining.Solution
IntoChainSystemsignature and implementation..system()in the chaining example, to verify the implementation.I swear, I'm not splitting these up on purpose, I just legit forgot about most of the things where
Systemappears in public API, and my trait usage explorer mingles that with the gajillion internal uses.In case you're wondering what happened to part 5, #2446 ate it.