[Merged by Bors] - Dedupe move logic in remove_bundle and remove_bundle_intersection#2521
Closed
BoxyUwU wants to merge 6 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Dedupe move logic in remove_bundle and remove_bundle_intersection#2521BoxyUwU wants to merge 6 commits intobevyengine:mainfrom
BoxyUwU wants to merge 6 commits intobevyengine:mainfrom
Conversation
github-actions
bot
added
S-Needs-Triage
BoxyUwU
force-pushed
the
dedupe_move_logic
branch
from
21eceb2 to
d1cad57
Compare
Member
|
while I like const generics, what's the benefit here over an additional parameter? |
Member
Author
|
I was thinking that it would mean that the branch wouldn't be there 🤔 i would hope this gets inlined and the branch to get optimized out even if this was a parameter though |
Contributor
|
Yeah, the monomorphization would definitely help reduce the chance of branching. Whether it's worth it or not should (imo) be based on how often this function would hypothetically be called. |
alice-i-cecile
added
A-ECS
cart
added
the
S-Pre-Relicense
mockersf
reviewed
Jul 24, 2021
mockersf
approved these changes
Jul 24, 2021
mockersf
removed
the
S-Pre-Relicense
mockersf
approved these changes
Jul 24, 2021
alice-i-cecile
approved these changes
Jul 24, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
Contributor
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This logic was in both
remove_bundleandremove_bundle_intersectionbut only differed by whether we call.._forget_missing_..or.._drop_missing_..