[Merged by Bors] - Ci stability and speed improvements#2551
Closed
mockersf wants to merge 6 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Ci stability and speed improvements#2551mockersf wants to merge 6 commits intobevyengine:mainfrom
mockersf wants to merge 6 commits intobevyengine:mainfrom
Conversation
mockersf
added
the
A-Build-System
Member
|
Good calls all round. I wish the dead link checker could do retries internally (they have hard coded support for 429 error retries, but nothing more). But this seems like a reasonable workaround in the interim. |
Member
|
The retry ran in ~13 minutes, which lines up with the numbers you reported. Awesome! |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
# Objective - There are a few random failures in CI, mostly due to contacting crates.io or checking for deadlinks - CI can take some time, more than 20 minutes for a full status - A clippy/format issue stops running tests on other platforms ## Solution - Use GitHub cache for cargo artefacts - This speeds up builds and reduce dependencies on outside world - Reorder and add dependencies between short jobs. They are still setup to run even if one of the dependency failed - This reduce the number of parallel jobs that are running for one PR. On GitHub free tier, we're limited to 20. - Split CI checks (format & clippy) in its own job - This speeds up test jobs, and allow us to not kill all platform tests for a format issue - Retry in case of dead links check failure - Internet is just that kind of place where things may seem dead at some point but back alive 5 seconds later ## Before <img width="1062" alt="Screenshot 2021-07-27 at 01 18 52" src="https://user-images.githubusercontent.com/8672791/127071973-9a2c5ce8-c871-4f8d-9b17-08871824b6c4.png"> ## After (with all cache live) <img width="1063" alt="Screenshot 2021-07-27 at 01 18 28" src="https://user-images.githubusercontent.com/8672791/127071986-767a7e65-53ed-45fd-8d75-51a571f0b851.png">
Contributor
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Aug 6, 2021
# Objective - #2551 revamped our CI setup which included running clippy and rustfmt in another Job. - This new Job wasn't added to the bors.toml, which means that PRs would be accepted that didn't run them. ## Solution - Add the "ci" job to the bors.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Before
After (with all cache live)