[Merged by Bors] - Bump notify to 5.0.0-pre.11#2564
Closed
deontologician wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Bump notify to 5.0.0-pre.11#2564deontologician wants to merge 1 commit intobevyengine:mainfrom
deontologician wants to merge 1 commit intobevyengine:mainfrom
Conversation
Contributor
I believe there was discussion on discord about chosing I assume |
bjorn3
added
A-Assets
Member
|
Replaces #2545 Yup, the idea was to fix for a patch with the smallest change possible, and that was using the last known working version. Thank you for the followup pr! |
Member
|
bors try |
Contributor
tryTimed out. |
Contributor
Author
bogus |
mockersf
approved these changes
Jul 29, 2021
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 29, 2021
# Objective notify 5.0.0-pre.11 breaks the interface again, but apparently in a way that's similar to how it used to be ## Solution Bump `bevy_asset` dependency on notify to `5.0.0-pre.11` and fix the errors that crop up. It looks like `pre.11` was mentioned in #2528 by @mockersf but there's no mention of why `pre.10` was chosen ultimately.
Contributor
bors
bot
changed the title
vabrador
pushed a commit
to vabrador/bevy
that referenced
this pull request
Sep 18, 2021
# Objective notify 5.0.0-pre.11 breaks the interface again, but apparently in a way that's similar to how it used to be ## Solution Bump `bevy_asset` dependency on notify to `5.0.0-pre.11` and fix the errors that crop up. It looks like `pre.11` was mentioned in bevyengine#2528 by @mockersf but there's no mention of why `pre.10` was chosen ultimately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
notify 5.0.0-pre.11 breaks the interface again, but apparently in a way that's similar to how it used to be
Solution
Bump
bevy_assetdependency on notify to5.0.0-pre.11and fix the errors that crop up.It looks like
pre.11was mentioned in #2528 by @mockersf but there's no mention of whypre.10was chosen ultimately.